]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
selftests: kselftest: fix wrong test number in ksft_exit_skip
authorSarthak Sharma <sarthak.sharma@arm.com>
Mon, 27 Apr 2026 11:24:47 +0000 (16:54 +0530)
committerShuah Khan <skhan@linuxfoundation.org>
Mon, 27 Apr 2026 16:48:24 +0000 (10:48 -0600)
ksft_exit_skip() increments ksft_xskip before printing the KTAP
result. As a result, ksft_test_num() already includes the skipped
test.

Adding 1 to ksft_test_num() increments the printed test number
again, producing an incorrect test number and wrong KTAP output.

Drop the extra increment and print ksft_test_num() directly.

Link: https://lore.kernel.org/r/20260427112447.147985-1-sarthak.sharma@arm.com
Fixes: b85d387c9b09 ("kselftest: fix TAP output for skipped tests")
Signed-off-by: Sarthak Sharma <sarthak.sharma@arm.com>
Signed-off-by: Shuah Khan <skhan@linuxfoundation.org>
tools/testing/selftests/kselftest.h

index 6d809f08ab7b1b5e20797a341faaffa0ff772f7a..60838b61a2da5233e65cb51ea05c389bb1ab98c7 100644 (file)
@@ -450,7 +450,7 @@ static inline __noreturn __printf(1, 2) void ksft_exit_skip(const char *msg, ...
         */
        if (ksft_plan || ksft_test_num()) {
                ksft_cnt.ksft_xskip++;
-               printf("ok %u # SKIP ", 1 + ksft_test_num());
+               printf("ok %u # SKIP ", ksft_test_num());
        } else {
                printf("1..0 # SKIP ");
        }