]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
accel/amdxdna: Fix incorrect error code returned for failed chain command
authorLizhi Hou <lizhi.hou@amd.com>
Tue, 3 Feb 2026 18:40:37 +0000 (10:40 -0800)
committerLizhi Hou <lizhi.hou@amd.com>
Tue, 3 Feb 2026 19:35:53 +0000 (11:35 -0800)
The driver currently returns an incorrect error code when a chain command
fails. In this case, ERT_CMD_STATE_ERROR is expected to be reported for
failed chain commands.

Fixes: aac243092b70 ("accel/amdxdna: Add command execution")
Reviewed-by: Mario Limonciello (AMD) <superm1@kernel.org>
Reviewed-by: Maciej Falkowski <maciej.falkowski@linux.intel.com>
Signed-off-by: Lizhi Hou <lizhi.hou@amd.com>
Link: https://patch.msgid.link/20260203184037.2751889-1-lizhi.hou@amd.com
drivers/accel/amdxdna/aie2_ctx.c

index ad5b5cd0bc81fa1aca6583cfc9862d00a8b9e265..fe8f9783a73c731335f3554c9041f2da340980f0 100644 (file)
@@ -274,7 +274,7 @@ aie2_sched_cmdlist_resp_handler(void *handle, void __iomem *data, size_t size)
                ret = -EINVAL;
                goto out;
        }
-       amdxdna_cmd_set_state(cmd_abo, fail_cmd_status);
+       amdxdna_cmd_set_state(cmd_abo, ERT_CMD_STATE_ERROR);
 
        if (amdxdna_cmd_get_op(cmd_abo) == ERT_CMD_CHAIN) {
                struct amdxdna_cmd_chain *cc = amdxdna_cmd_get_payload(cmd_abo, NULL);