Fix cgclear to continue unmounting on error

Currently when the cgclear stumbles upon a mount point which cannot be
removed it exits immediatelly. IMHO it should continue clearing the rest
and unmount as much as possible.

Signed-off-by: Jan Safranek <jsafrane@redhat.com>
Acked-by: Dhaval Giani <dhaval.giani@gmail.com>

diff --git a/src/config.c b/src/config.c
index 23e1e430d419e58b7b1195da3c0c9c3eebbfbb22..0f71003f3755f59750d214b079e986191d3b2f1d 100644 (file)
--- a/src/config.c
+++ b/src/config.c
@@ -780,8 +780,6 @@ int cgroup_unload_cgroups(void)
        }
 
        error = cgroup_get_controller_begin(&ctrl_handle, &info);
-
-
        if (error && error != ECGEOF) {
                ret = error;
                goto out_error;
@@ -796,10 +794,13 @@ int cgroup_unload_cgroups(void)
                        if (!curr_path)
                                goto out_errno;
 
-                       ret = cgroup_config_unload_controller(&info);
-
-                       if (ret)
-                               goto out_error;
+                       error = cgroup_config_unload_controller(&info);
+                       if (error) {
+                               /* remember the error and continue unloading
+                                * the rest */
+                               ret = error;
+                               error = 0;
+                       }
                }
 
                error = cgroup_get_controller_next(&ctrl_handle, &info);