]> git.ipfire.org Git - thirdparty/gcc.git/commitdiff
Fix PR 102908: wrongly removing null pointer loads
authorAndrew Pinski <apinski@marvell.com>
Sat, 23 Oct 2021 19:24:43 +0000 (19:24 +0000)
committerAndrew Pinski <apinski@marvell.com>
Mon, 25 Oct 2021 12:08:37 +0000 (12:08 +0000)
Just like PR 100382, here we have a DCE removing a
null pointer load which is needed still.
In this case, execute_fixup_cfg removes a store (correctly)
and then removes the null load (incorrectly) due to
not checking stmt_unremovable_because_of_non_call_eh_p.
This patch adds the check in the similar way as the patch
to fix PR 100382 did.

gcc/ChangeLog:

* tree-ssa-dce.c (simple_dce_from_worklist):
Check stmt_unremovable_because_of_non_call_eh_p also
before removing the statement.

gcc/tree-ssa-dce.c

index 372e0691ae63bb5f622f9a40deda26ec6e97e237..1281e67489c056a5d027482a55c5afc5d2453a0b 100644 (file)
@@ -1828,6 +1828,11 @@ simple_dce_from_worklist (bitmap worklist)
       if (gimple_has_side_effects (t))
        continue;
 
+      /* Don't remove statements that are needed for non-call
+        eh to work.  */
+      if (stmt_unremovable_because_of_non_call_eh_p (cfun, t))
+       continue;
+
       /* Add uses to the worklist.  */
       ssa_op_iter iter;
       use_operand_p use_p;