]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
platform/x86: yogabook: Clean up code style
authorBenjamin Philip <benjamin.philip495@gmail.com>
Thu, 1 Jan 2026 14:16:57 +0000 (19:46 +0530)
committerIlpo Järvinen <ilpo.jarvinen@linux.intel.com>
Tue, 6 Jan 2026 08:51:24 +0000 (10:51 +0200)
This commit cleans up the following checks flagged by checkpatch in
yogabook.c:

- CHECK: Prefer kernel type 'u8' over 'uint8_t'
- CHECK: Comparison to NULL could be written "!data"
- CHECK: line length of ... exceeds 100 columns

Signed-off-by: Benjamin Philip <benjamin.philip495@gmail.com>
Reviewed-by: Hans de Goede <johannes.goede@oss.qualcomm.com>
Reviewed-by: Mark Pearson <mpearson-lenovo@squebb.ca>
Link: https://patch.msgid.link/20260101141657.54258-1-benjamin.philip495@gmail.com
Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
drivers/platform/x86/lenovo/yogabook.c

index 31b298dc5046f810775a98585cfced0ee0fb8e29..69887de36c9b9018c8ada9dcdcd69cea3ab98d60 100644 (file)
@@ -57,7 +57,7 @@ struct yogabook_data {
        struct work_struct work;
        struct led_classdev kbd_bl_led;
        unsigned long flags;
-       uint8_t brightness;
+       u8 brightness;
 };
 
 static void yogabook_work(struct work_struct *work)
@@ -338,16 +338,18 @@ static int yogabook_wmi_probe(struct wmi_device *wdev, const void *context)
        int r;
 
        data = devm_kzalloc(dev, sizeof(*data), GFP_KERNEL);
-       if (data == NULL)
+       if (!data)
                return -ENOMEM;
 
        data->kbd_adev = acpi_dev_get_first_match_dev("GDIX1001", NULL, -1);
        if (!data->kbd_adev)
-               return dev_err_probe(dev, -ENODEV, "Cannot find the touchpad device in ACPI tables\n");
+               return dev_err_probe(dev, -ENODEV,
+                                    "Cannot find the touchpad device in ACPI tables\n");
 
        data->dig_adev = acpi_dev_get_first_match_dev("WCOM0019", NULL, -1);
        if (!data->dig_adev) {
-               r = dev_err_probe(dev, -ENODEV, "Cannot find the digitizer device in ACPI tables\n");
+               r = dev_err_probe(dev, -ENODEV,
+                                 "Cannot find the digitizer device in ACPI tables\n");
                goto error_put_devs;
        }
 
@@ -453,7 +455,7 @@ static int yogabook_pdev_probe(struct platform_device *pdev)
        int r;
 
        data = devm_kzalloc(dev, sizeof(*data), GFP_KERNEL);
-       if (data == NULL)
+       if (!data)
                return -ENOMEM;
 
        data->kbd_dev = bus_find_device_by_name(&i2c_bus_type, NULL, "i2c-goodix_ts");