]> git.ipfire.org Git - thirdparty/samba.git/commitdiff
smbd: always use check_access_fsp() in smb_set_file_basic_info()
authorRalph Boehme <slow@samba.org>
Tue, 27 Oct 2020 20:13:12 +0000 (21:13 +0100)
committerRalph Boehme <slow@samba.org>
Wed, 16 Dec 2020 09:08:31 +0000 (09:08 +0000)
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
source3/smbd/trans2.c

index 5ab3c285ca7b52c18d2f96efb82b2be6263174b6..a2196b7099521aa33a0103a85c908bbdc92b0723 100644 (file)
@@ -7838,15 +7838,7 @@ static NTSTATUS smb_set_file_basic_info(connection_struct *conn,
                return NT_STATUS_INVALID_PARAMETER;
        }
 
-       if (fsp != NULL) {
-               status = check_access_fsp(fsp, FILE_WRITE_ATTRIBUTES);
-       } else {
-               status = smbd_check_access_rights(conn,
-                               conn->cwd_fsp,
-                               smb_fname,
-                               false,
-                               FILE_WRITE_ATTRIBUTES);
-       }
+       status = check_access_fsp(fsp, FILE_WRITE_ATTRIBUTES);
        if (!NT_STATUS_IS_OK(status)) {
                return status;
        }