drm/i915/psr: Do not use pipe_src as borders for SU area

This far using crtc_state->pipe_src as borders for Selective Update area
haven't caused visible problems as drm_rect_width(crtc_state->pipe_src) ==
crtc_state->hw.adjusted_mode.crtc_hdisplay and
drm_rect_height(crtc_state->pipe_src) ==
crtc_state->hw.adjusted_mode.crtc_vdisplay when pipe scaling is not
used. On the other hand using pipe scaling is forcing full frame updates and all the
Selective Update area calculations are skipped. Now this improper usage of
crtc_state->pipe_src is causing following warnings:

<4> [7771.978166] xe 0000:00:02.0: [drm] drm_WARN_ON_ONCE(su_lines % vdsc_cfg->slice_height)

after WARN_ON_ONCE was added by commit:

"drm/i915/dsc: Add helper for writing DSC Selective Update ET parameters"

These warnings are seen when DSC and pipe scaling are enabled
simultaneously. This is because on full frame update SU area is improperly
set as pipe_src which is not aligned with DSC slice height.

Fix these by creating local rectangle using
crtc_state->hw.adjusted_mode.crtc_hdisplay and
crtc_state->hw.adjusted_mode.crtc_vdisplay. Use this local rectangle as
borders for SU area.

Fixes: d6774b8c3c58 ("drm/i915: Ensure damage clip area is within pipe area")
Cc: <stable@vger.kernel.org> # v6.0+
Signed-off-by: Jouni Högander <jouni.hogander@intel.com>
Reviewed-by: Mika Kahola <mika.kahola@intel.com>
Link: https://patch.msgid.link/20260327114553.195285-1-jouni.hogander@intel.com
(cherry picked from commit da0cdc1c329dd2ff09c41fbbe9fbd9c92c5d2c6e)
Signed-off-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>

diff --git a/drivers/gpu/drm/i915/display/intel_psr.c b/drivers/gpu/drm/i915/display/intel_psr.c
index 3791944389db0cfb0051c326159eeb1c370d0f0d..097e18c1adb279bf9eafe17280b2a2799f6ceee4 100644 (file)
--- a/drivers/gpu/drm/i915/display/intel_psr.c
+++ b/drivers/gpu/drm/i915/display/intel_psr.c
@@ -2678,9 +2678,9 @@ static u32 psr2_pipe_srcsz_early_tpt_calc(struct intel_crtc_state *crtc_state,
 
 static void clip_area_update(struct drm_rect *overlap_damage_area,
                             struct drm_rect *damage_area,
-                            struct drm_rect *pipe_src)
+                            struct drm_rect *display_area)
 {
-       if (!drm_rect_intersect(damage_area, pipe_src))
+       if (!drm_rect_intersect(damage_area, display_area))
                return;
 
        if (overlap_damage_area->y1 == -1) {
@@ -2731,6 +2731,7 @@ static bool intel_psr2_sel_fetch_pipe_alignment(struct intel_crtc_state *crtc_st
 static void
 intel_psr2_sel_fetch_et_alignment(struct intel_atomic_state *state,
                                  struct intel_crtc *crtc,
+                                 struct drm_rect *display_area,
                                  bool *cursor_in_su_area)
 {
        struct intel_crtc_state *crtc_state = intel_atomic_get_new_crtc_state(state, crtc);
@@ -2758,7 +2759,7 @@ intel_psr2_sel_fetch_et_alignment(struct intel_atomic_state *state,
                        continue;
 
                clip_area_update(&crtc_state->psr2_su_area, &new_plane_state->uapi.dst,
-                                &crtc_state->pipe_src);
+                                display_area);
                *cursor_in_su_area = true;
        }
 }
@@ -2855,6 +2856,12 @@ int intel_psr2_sel_fetch_update(struct intel_atomic_state *state,
        struct intel_crtc_state *crtc_state = intel_atomic_get_new_crtc_state(state, crtc);
        struct intel_plane_state *new_plane_state, *old_plane_state;
        struct intel_plane *plane;
+       struct drm_rect display_area = {
+               .x1 = 0,
+               .y1 = 0,
+               .x2 = crtc_state->hw.adjusted_mode.crtc_hdisplay,
+               .y2 = crtc_state->hw.adjusted_mode.crtc_vdisplay,
+       };
        bool full_update = false, su_area_changed;
        int i, ret;
 
@@ -2868,7 +2875,7 @@ int intel_psr2_sel_fetch_update(struct intel_atomic_state *state,
 
        crtc_state->psr2_su_area.x1 = 0;
        crtc_state->psr2_su_area.y1 = -1;
-       crtc_state->psr2_su_area.x2 = drm_rect_width(&crtc_state->pipe_src);
+       crtc_state->psr2_su_area.x2 = drm_rect_width(&display_area);
        crtc_state->psr2_su_area.y2 = -1;
 
        /*
@@ -2906,14 +2913,14 @@ int intel_psr2_sel_fetch_update(struct intel_atomic_state *state,
                                damaged_area.y1 = old_plane_state->uapi.dst.y1;
                                damaged_area.y2 = old_plane_state->uapi.dst.y2;
                                clip_area_update(&crtc_state->psr2_su_area, &damaged_area,
-                                                &crtc_state->pipe_src);
+                                                &display_area);
                        }
 
                        if (new_plane_state->uapi.visible) {
                                damaged_area.y1 = new_plane_state->uapi.dst.y1;
                                damaged_area.y2 = new_plane_state->uapi.dst.y2;
                                clip_area_update(&crtc_state->psr2_su_area, &damaged_area,
-                                                &crtc_state->pipe_src);
+                                                &display_area);
                        }
                        continue;
                } else if (new_plane_state->uapi.alpha != old_plane_state->uapi.alpha) {
@@ -2921,7 +2928,7 @@ int intel_psr2_sel_fetch_update(struct intel_atomic_state *state,
                        damaged_area.y1 = new_plane_state->uapi.dst.y1;
                        damaged_area.y2 = new_plane_state->uapi.dst.y2;
                        clip_area_update(&crtc_state->psr2_su_area, &damaged_area,
-                                        &crtc_state->pipe_src);
+                                        &display_area);
                        continue;
                }
 
@@ -2937,7 +2944,7 @@ int intel_psr2_sel_fetch_update(struct intel_atomic_state *state,
                damaged_area.x1 += new_plane_state->uapi.dst.x1 - src.x1;
                damaged_area.x2 += new_plane_state->uapi.dst.x1 - src.x1;
 
-               clip_area_update(&crtc_state->psr2_su_area, &damaged_area, &crtc_state->pipe_src);
+               clip_area_update(&crtc_state->psr2_su_area, &damaged_area, &display_area);
        }
 
        /*
@@ -2972,7 +2979,8 @@ int intel_psr2_sel_fetch_update(struct intel_atomic_state *state,
                 * cursor is added into affected planes even when
                 * cursor is not updated by itself.
                 */
-               intel_psr2_sel_fetch_et_alignment(state, crtc, &cursor_in_su_area);
+               intel_psr2_sel_fetch_et_alignment(state, crtc, &display_area,
+                                                 &cursor_in_su_area);
 
                su_area_changed = intel_psr2_sel_fetch_pipe_alignment(crtc_state);
 
@@ -3048,8 +3056,8 @@ int intel_psr2_sel_fetch_update(struct intel_atomic_state *state,
 
 skip_sel_fetch_set_loop:
        if (full_update)
-               clip_area_update(&crtc_state->psr2_su_area, &crtc_state->pipe_src,
-                                &crtc_state->pipe_src);
+               clip_area_update(&crtc_state->psr2_su_area, &display_area,
+                                &display_area);
 
        psr2_man_trk_ctl_calc(crtc_state, full_update);
        crtc_state->pipe_srcsz_early_tpt =