Mark instance as unused in %{rand:}

diff --git a/src/modules/rlm_expr/rlm_expr.c b/src/modules/rlm_expr/rlm_expr.c
index 3b81595bd925316a4739889b0cbb322ec79c6570..bc51ac8828a7d6e0abfcfd4ea5541390fa05023a 100644 (file)
--- a/src/modules/rlm_expr/rlm_expr.c
+++ b/src/modules/rlm_expr/rlm_expr.c
@@ -260,21 +260,23 @@ static size_t expr_xlat(void *instance, REQUEST *request, const char *fmt,
        return strlen(out);
 }
 
-static size_t rand_xlat(void *instance, REQUEST *request, const char *fmt,
+/**
+ *  @brief Generate a random integer value
+ *
+ */
+static size_t rand_xlat(UNUSED void *instance, REQUEST *request, const char *fmt,
                        char *out, size_t outlen,
                        RADIUS_ESCAPE_STRING func)
 {
        int64_t         result;
-       rlm_expr_t      *inst = instance;
        char            buffer[256];
 
-       inst = inst;            /* -Wunused */
-
        /*
         * Do an xlat on the provided string (nice recursive operation).
         */
        if (!radius_xlat(buffer, sizeof(buffer), fmt, request, func)) {
                radlog(L_ERR, "rlm_expr: xlat failed.");
+               *out = '\0';
                return 0;
        }