]> git.ipfire.org Git - thirdparty/suricata.git/commitdiff
detect/csum: rm interaction btw stream setting/csum
authorJeff Lucovsky <jlucovsky@oisf.net>
Mon, 20 Jan 2025 13:46:39 +0000 (08:46 -0500)
committerVictor Julien <victor@inliniac.net>
Tue, 28 Jan 2025 21:34:30 +0000 (22:34 +0100)
Issue: 7467

Stream checksum validation no longer has a side effect of setting
PKT_IGNORE_CHECKSUM and thus, no longer affects csum keyword checks.

src/stream-tcp.c

index 7352f2bdc74fd31291684a2497a64aabe3943fa7..f0e5f3bcf30c5876be5fd51b26b8a6c70f9d878d 100644 (file)
@@ -5958,11 +5958,7 @@ TmEcode StreamTcp (ThreadVars *tv, Packet *p, void *data, PacketQueueNoLock *pq)
                 StatsIncr(tv, stt->counter_tcp_invalid_checksum);
                 return TM_ECODE_OK;
             }
-        } else {
-            p->flags |= PKT_IGNORE_CHECKSUM;
         }
-    } else {
-        p->flags |= PKT_IGNORE_CHECKSUM; //TODO check that this is set at creation
     }
     AppLayerProfilingReset(stt->ra_ctx->app_tctx);