]> git.ipfire.org Git - thirdparty/u-boot.git/commitdiff
usb: dwc3: Increase DWC3 controller halt timeout
authorChris Morgan <macromorgan@hotmail.com>
Thu, 15 Jan 2026 23:01:33 +0000 (17:01 -0600)
committerMattijs Korpershoek <mkorpershoek@kernel.org>
Fri, 30 Jan 2026 07:59:21 +0000 (08:59 +0100)
Since EP0 transactions need to be completed before the controller halt
sequence is finished, this may take some time depending on the host and the
enabled functions.  Increase the controller halt timeout, so that we give
the controller sufficient time to handle EP0 transfers.

This patch was originally submitted to Linux in 2022, but is required to
use USB gadget mode on my device in U-Boot.

[1] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=461ee467507cb98a348fa91ff8460908bb0ea423

Signed-off-by: Wesley Cheng <quic_wcheng@quicinc.com>
Signed-off-by: Chris Morgan <macromorgan@hotmail.com>
Reviewed-by: Mattijs Korpershoek <mkorpershoek@kernel.org>
Link: https://lore.kernel.org/r/20260115230135.183158-3-macroalpha82@gmail.com
Signed-off-by: Mattijs Korpershoek <mkorpershoek@kernel.org>
drivers/usb/dwc3/gadget.c

index 2b01113d54cdda634dd690b60727f8b64c169fbe..d2ae892d5544d62d304d599fb1c89a9133746d95 100644 (file)
@@ -1396,7 +1396,7 @@ static int dwc3_gadget_set_selfpowered(struct usb_gadget *g,
 static int dwc3_gadget_run_stop(struct dwc3 *dwc, int is_on, int suspend)
 {
        u32                     reg;
-       u32                     timeout = 500;
+       u32                     timeout = 2000;
 
        reg = dwc3_readl(dwc->regs, DWC3_DCTL);
        if (is_on) {
@@ -1425,6 +1425,7 @@ static int dwc3_gadget_run_stop(struct dwc3 *dwc, int is_on, int suspend)
        dwc3_writel(dwc->regs, DWC3_DCTL, reg);
 
        do {
+               udelay(2000);
                reg = dwc3_readl(dwc->regs, DWC3_DSTS);
                if (is_on) {
                        if (!(reg & DWC3_DSTS_DEVCTRLHLT))
@@ -1436,7 +1437,6 @@ static int dwc3_gadget_run_stop(struct dwc3 *dwc, int is_on, int suspend)
                timeout--;
                if (!timeout)
                        return -ETIMEDOUT;
-               udelay(1);
        } while (1);
 
        dev_vdbg(dwc->dev, "gadget %s data soft-%s\n",