]> git.ipfire.org Git - thirdparty/freeradius-server.git/commitdiff
Move use of name after NULL check in dict_by_protocol_substr (CID #1503920) (#4481)
authorJames Jones <jejones3141@gmail.com>
Fri, 29 Apr 2022 19:14:50 +0000 (14:14 -0500)
committerGitHub <noreply@github.com>
Fri, 29 Apr 2022 19:14:50 +0000 (15:14 -0400)
src/lib/util/dict_util.c

index 5bb9234ed9a8467b10cad4ab71e29dc8a257e339..75f5f21f7cde305ea8c5dac3bdf795757a6bf19d 100644 (file)
@@ -1957,13 +1957,15 @@ ssize_t dict_by_protocol_substr(fr_dict_attr_err_t *err,
        fr_dict_t               *dict;
        size_t                  len;
        char                    buffer[FR_DICT_ATTR_MAX_NAME_LEN + 1 + 1];      /* +1 \0 +1 for "too long" */
-       fr_sbuff_t              our_name = FR_SBUFF(name);
+       fr_sbuff_t              our_name;
 
        if (!dict_gctx || !name || !out) {
                if (err) *err = FR_DICT_ATTR_EINVAL;
                return 0;
        }
 
+       our_name = FR_SBUFF(name);
+
        memset(&root, 0, sizeof(root));
 
        /*