]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
platform/x86/intel/pmt: mutex clean up
authorMichael J. Ruhl <michael.j.ruhl@intel.com>
Sun, 13 Jul 2025 17:29:35 +0000 (13:29 -0400)
committerIlpo Järvinen <ilpo.jarvinen@linux.intel.com>
Tue, 22 Jul 2025 14:38:54 +0000 (17:38 +0300)
The header file for mutex usage and mutex_destroy() cleanup code is
absent from the crashlog.c module.

Add the header file and mutex_destroy().

Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
Signed-off-by: Michael J. Ruhl <michael.j.ruhl@intel.com>
Link: https://lore.kernel.org/r/20250713172943.7335-6-michael.j.ruhl@intel.com
Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
drivers/platform/x86/intel/pmt/crashlog.c

index d40c8e212733e74f9d1460613caaff91211637e0..6e32fc1f8f1d82c7a348f40fbff6b3779b788969 100644 (file)
@@ -12,6 +12,7 @@
 #include <linux/intel_vsec.h>
 #include <linux/kernel.h>
 #include <linux/module.h>
+#include <linux/mutex.h>
 #include <linux/pci.h>
 #include <linux/slab.h>
 #include <linux/uaccess.h>
@@ -262,8 +263,12 @@ static void pmt_crashlog_remove(struct auxiliary_device *auxdev)
        struct pmt_crashlog_priv *priv = auxiliary_get_drvdata(auxdev);
        int i;
 
-       for (i = 0; i < priv->num_entries; i++)
-               intel_pmt_dev_destroy(&priv->entry[i].entry, &pmt_crashlog_ns);
+       for (i = 0; i < priv->num_entries; i++) {
+               struct crashlog_entry *crashlog = &priv->entry[i];
+
+               intel_pmt_dev_destroy(&crashlog->entry, &pmt_crashlog_ns);
+               mutex_destroy(&crashlog->control_mutex);
+       }
 }
 
 static int pmt_crashlog_probe(struct auxiliary_device *auxdev,