]> git.ipfire.org Git - thirdparty/freeswitch.git/commitdiff
Avoid useless NAT log message
authorTravis Cross <tc@traviscross.com>
Sat, 24 May 2014 00:34:12 +0000 (00:34 +0000)
committerTravis Cross <tc@traviscross.com>
Sat, 24 May 2014 18:24:54 +0000 (18:24 +0000)
If FS is not behind NAT, then every call generates at least three
INFO-level log messages:

  [INFO] switch_nat.c:589 NAT port mapping disabled

This is useless noise.  The message is only interesting if you do have
NAT enabled but mapping disabled, which might indicate a configuration
issue.

With this change, we just skip the entire nat_add_mapping function if
the NAT system isn't initialized or we're not behind NAT.

src/switch_nat.c

index ff1b68d6283f524636b25f97072faad4befc9fde..332ad43c7f1aa335922fe585b69a016d95574c2b 100644 (file)
@@ -586,6 +586,7 @@ SWITCH_DECLARE(switch_status_t) switch_nat_add_mapping_internal(switch_port_t po
        switch_status_t status = SWITCH_STATUS_FALSE;
        switch_event_t *event = NULL;
 
+       if (!initialized || !nat_globals.nat_type) return status;
        if (!nat_globals.mapping) {
                switch_log_printf(SWITCH_CHANNEL_LOG, SWITCH_LOG_INFO, "NAT port mapping disabled\n");
                return status;