]> git.ipfire.org Git - thirdparty/libvirt.git/commitdiff
remote: remove variable whose value is a constant
authorDaniel P. Berrangé <berrange@redhat.com>
Fri, 25 Jan 2019 11:09:10 +0000 (11:09 +0000)
committerDaniel P. Berrangé <berrange@redhat.com>
Thu, 31 Jan 2019 10:38:30 +0000 (10:38 +0000)
The 'rv' variable is never changed after being declared, so can be
removed.

Reviewed-by: John Ferlan <jferlan@redhat.com>
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
src/remote/remote_daemon_dispatch.c

index fcd602304fc56905bbac3d034b8172d4168f2724..df28259042d88d09f899af3de5dff57c6540cc2d 100644 (file)
@@ -3659,7 +3659,6 @@ remoteDispatchAuthSaslStart(virNetServerPtr server,
     const char *serverout;
     size_t serveroutlen;
     int err;
-    int rv = -1;
     struct daemonClientPrivate *priv =
         virNetServerClientGetPrivateData(client);
     const char *identity;
@@ -3739,8 +3738,7 @@ remoteDispatchAuthSaslStart(virNetServerPtr server,
     virResetLastError();
     virReportError(VIR_ERR_AUTH_FAILED, "%s",
                    _("authentication failed"));
-    if (rv < 0)
-        virNetMessageSaveError(rerr);
+    virNetMessageSaveError(rerr);
     virMutexUnlock(&priv->lock);
     return -1;
 }
@@ -3757,7 +3755,6 @@ remoteDispatchAuthSaslStep(virNetServerPtr server,
     const char *serverout;
     size_t serveroutlen;
     int err;
-    int rv = -1;
     struct daemonClientPrivate *priv =
         virNetServerClientGetPrivateData(client);
     const char *identity;
@@ -3837,8 +3834,7 @@ remoteDispatchAuthSaslStep(virNetServerPtr server,
     virResetLastError();
     virReportError(VIR_ERR_AUTH_FAILED, "%s",
                    _("authentication failed"));
-    if (rv < 0)
-        virNetMessageSaveError(rerr);
+    virNetMessageSaveError(rerr);
     virMutexUnlock(&priv->lock);
     return -1;
 }