media: saa7164: Remove unused functions

saa7164_cmd_signal() last use was removed in 2009 by
commit 39e469ab6dee ("V4L/DVB (12940): SAA7164: IRQ / message timeout
related change")

saa7164_buffer_display() was added in 2010 by
commit add3f580a434 ("[media] saa7164: convert buffering structs to be more
generic")
but is unused.

Remove them.

Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>
Signed-off-by: Hans Verkuil <hverkuil@xs4all.nl>

diff --git a/drivers/media/pci/saa7164/saa7164-buffer.c b/drivers/media/pci/saa7164/saa7164-buffer.c
index 89c5b79a5b249996fa0c5e5de1b99a8ffbe15a38..7820e4f47fd5c2609eca9fc7d41fc4269271352f 100644 (file)
--- a/drivers/media/pci/saa7164/saa7164-buffer.c
+++ b/drivers/media/pci/saa7164/saa7164-buffer.c
@@ -52,26 +52,6 @@
  *                                                 | etc
  */
 
-void saa7164_buffer_display(struct saa7164_buffer *buf)
-{
-       struct saa7164_dev *dev = buf->port->dev;
-       int i;
-
-       dprintk(DBGLVL_BUF, "%s()   buffer @ 0x%p nr=%d\n",
-               __func__, buf, buf->idx);
-       dprintk(DBGLVL_BUF, "  pci_cpu @ 0x%p    dma @ 0x%08llx len = 0x%x\n",
-               buf->cpu, (long long)buf->dma, buf->pci_size);
-       dprintk(DBGLVL_BUF, "   pt_cpu @ 0x%p pt_dma @ 0x%08llx len = 0x%x\n",
-               buf->pt_cpu, (long long)buf->pt_dma, buf->pt_size);
-
-       /* Format the Page Table Entries to point into the data buffer */
-       for (i = 0 ; i < SAA7164_PT_ENTRIES; i++) {
-
-               dprintk(DBGLVL_BUF, "    pt[%02d] = 0x%p -> 0x%llx\n",
-                       i, buf->pt_cpu, (u64)*(buf->pt_cpu));
-
-       }
-}
 /* Allocate a new buffer structure and associated PCI space in bytes.
  * len must be a multiple of sizeof(u64)
  */

diff --git a/drivers/media/pci/saa7164/saa7164-cmd.c b/drivers/media/pci/saa7164/saa7164-cmd.c
index 42bd8e76005be69b667b060e30f50d96bcd43999..a95662776ee8142cf930cb35574fb07f7a14b19f 100644 (file)
--- a/drivers/media/pci/saa7164/saa7164-cmd.c
+++ b/drivers/media/pci/saa7164/saa7164-cmd.c
@@ -295,34 +295,6 @@ static int saa7164_cmd_wait(struct saa7164_dev *dev, u8 seqno)
        return ret;
 }
 
-void saa7164_cmd_signal(struct saa7164_dev *dev, u8 seqno)
-{
-       int i;
-       dprintk(DBGLVL_CMD, "%s()\n", __func__);
-
-       mutex_lock(&dev->lock);
-       for (i = 0; i < SAA_CMD_MAX_MSG_UNITS; i++) {
-               if (dev->cmds[i].inuse == 1) {
-                       dprintk(DBGLVL_CMD,
-                               "seqno %d inuse, sig = %d, t/out = %d\n",
-                               dev->cmds[i].seqno,
-                               dev->cmds[i].signalled,
-                               dev->cmds[i].timeout);
-               }
-       }
-
-       for (i = 0; i < SAA_CMD_MAX_MSG_UNITS; i++) {
-               if ((dev->cmds[i].inuse == 1) && ((i == 0) ||
-                       (dev->cmds[i].signalled) || (dev->cmds[i].timeout))) {
-                       dprintk(DBGLVL_CMD, "%s(seqno=%d) calling wake_up\n",
-                               __func__, i);
-                       dev->cmds[i].signalled = 1;
-                       wake_up(&dev->cmds[i].wait);
-               }
-       }
-       mutex_unlock(&dev->lock);
-}
-
 int saa7164_cmd_send(struct saa7164_dev *dev, u8 id, enum tmComResCmd command,
        u16 controlselector, u16 size, void *buf)
 {

diff --git a/drivers/media/pci/saa7164/saa7164.h b/drivers/media/pci/saa7164/saa7164.h
index eede47b686a3808acc40f0ccf8c2b5fecb1c2fe5..e1bac1fe19d3098792b2051b537857e3f13054d5 100644 (file)
--- a/drivers/media/pci/saa7164/saa7164.h
+++ b/drivers/media/pci/saa7164/saa7164.h
@@ -508,7 +508,6 @@ int saa7164_bus_get(struct saa7164_dev *dev, struct tmComResInfo* msg,
 int saa7164_cmd_send(struct saa7164_dev *dev,
        u8 id, enum tmComResCmd command, u16 controlselector,
        u16 size, void *buf);
-void saa7164_cmd_signal(struct saa7164_dev *dev, u8 seqno);
 int saa7164_irq_dequeue(struct saa7164_dev *dev);
 
 /* ----------------------------------------------------------- */
@@ -570,7 +569,6 @@ extern int saa7164_dvb_unregister(struct saa7164_port *port);
 extern struct saa7164_buffer *saa7164_buffer_alloc(
        struct saa7164_port *port, u32 len);
 extern int saa7164_buffer_dealloc(struct saa7164_buffer *buf);
-extern void saa7164_buffer_display(struct saa7164_buffer *buf);
 extern int saa7164_buffer_activate(struct saa7164_buffer *buf, int i);
 extern int saa7164_buffer_cfg_port(struct saa7164_port *port);
 extern struct saa7164_user_buffer *saa7164_buffer_alloc_user(