]> git.ipfire.org Git - thirdparty/libvirt.git/commitdiff
Fix broken formatting on OOM in xenFormatXM
authorDaniel P. Berrange <berrange@redhat.com>
Tue, 24 Sep 2013 15:45:58 +0000 (16:45 +0100)
committerDaniel P. Berrange <berrange@redhat.com>
Wed, 25 Sep 2013 14:49:28 +0000 (15:49 +0100)
If an OOM occurs when xenFormatXM is setting the 'hpet'
variable it is silently ignored. Fix it to propagate
to the callers.

Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
src/xenxs/xen_xm.c

index 1652fff7982e99729318350cad48cb921f2ddb2e..7550a07abc4262a77055b1bf8a724045ce8d3ba7 100644 (file)
@@ -1601,7 +1601,7 @@ virConfPtr xenFormatXM(virConnectPtr conn,
             if (def->clock.timers[i]->name == VIR_DOMAIN_TIMER_NAME_HPET &&
                 def->clock.timers[i]->present != -1 &&
                 xenXMConfigSetInt(conf, "hpet", def->clock.timers[i]->present) < 0)
-                    break;
+                goto cleanup;
         }
 
         if (xendConfigVersion == XEND_CONFIG_VERSION_3_0_2) {