]> git.ipfire.org Git - thirdparty/asterisk.git/commitdiff
Fix logic error when checking for a devstate provider.
authorMark Michelson <mmichelson@digium.com>
Mon, 17 May 2010 22:00:28 +0000 (22:00 +0000)
committerMark Michelson <mmichelson@digium.com>
Mon, 17 May 2010 22:00:28 +0000 (22:00 +0000)
When using strsep, if one of the list of specified separators is not found,
it is the first parameter to strsep which is now NULL, not the pointer returned
by strsep.

This issue isn't especially severe in that the worst it is likely to do is waste
some cycles when a device with no '/' and no ':' is passed to ast_device_state.

git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@263639 65c4cc65-6c06-0410-ace0-fbb531ad65f3

main/devicestate.c

index e1a52dd6363cab1495a19af2b8a76c82eebb3cd8..c8a7dc69c99700299934edc89e766bc95ae092be 100644 (file)
@@ -145,7 +145,7 @@ int ast_device_state(const char *device)
        number = buf;
        if (!number) {
                provider = strsep(&tech, ":");
-               if (!provider)
+               if (!tech)
                        return AST_DEVICE_INVALID;
                /* We have a provider */
                number = tech;