]> git.ipfire.org Git - thirdparty/libvirt.git/commitdiff
rpc: client: Don't check return value of virNetMessageNew
authorPeter Krempa <pkrempa@redhat.com>
Wed, 15 Feb 2023 09:43:53 +0000 (10:43 +0100)
committerPeter Krempa <pkrempa@redhat.com>
Wed, 15 Feb 2023 11:36:17 +0000 (12:36 +0100)
virNetServerClientDispatchRead checked the return value but it's not
necessary any more as it can't return NULL nowadays.

Signed-off-by: Peter Krempa <pkrempa@redhat.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
src/rpc/virnetserverclient.c

index c9a4eb521e39cb6b9aad85253d2421b68dbf8ea8..b5c764b1b0e2e74e9e8b26a0e4f64cb78467f499 100644 (file)
@@ -1257,13 +1257,10 @@ static virNetMessage *virNetServerClientDispatchRead(virNetServerClient *client)
 
         /* Possibly need to create another receive buffer */
         if (client->nrequests < client->nrequests_max) {
-            if (!(client->rx = virNetMessageNew(true))) {
-                client->wantClose = true;
-            } else {
-                client->rx->bufferLength = VIR_NET_MESSAGE_LEN_MAX;
-                client->rx->buffer = g_new0(char, client->rx->bufferLength);
-                client->nrequests++;
-            }
+            client->rx = virNetMessageNew(true);
+            client->rx->bufferLength = VIR_NET_MESSAGE_LEN_MAX;
+            client->rx->buffer = g_new0(char, client->rx->bufferLength);
+            client->nrequests++;
         } else if (!client->nrequests_warning) {
             client->nrequests_warning = true;
             VIR_WARN("Client hit max requests limit %zd. This may result "