networkEnableIpForwarding() now returns zero for success

diff --git a/ChangeLog b/ChangeLog
index ff6e08be1b5ef759ac3173c81491e0dc066a5282..677c584b62f3d4c274d40cde4ed5d1b2fa3751b0 100644 (file)
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,8 @@
+Sun Feb 22 11:18:20 GMT 2009 Mark McLoughlin <markmc@redhat.com>
+
+       * src/network_driver.c: networkEnableIpForwarding() now
+       returns zero for success
+
 Sun Feb 22 11:06:39 GMT 2009 Mark McLoughlin <markmc@redhat.com>
 
        * docs/formatdomain.html: commit auto-generated change as

diff --git a/src/network_driver.c b/src/network_driver.c
index b256e3d0256852c4711c18c56a1a8408f4acc7f5..3c765c8ec6f09921e2d4bad56efeaa311564fa64 100644 (file)
--- a/src/network_driver.c
+++ b/src/network_driver.c
@@ -794,7 +794,7 @@ networkRemoveIptablesRules(struct network_driver *driver,
     iptablesSaveRules(driver->iptables);
 }
 
-/* Enable IP Forwarding. Return 0 for success, nonzero for failure. */
+/* Enable IP Forwarding. Return 0 for success, -1 for failure. */
 static int
 networkEnableIpForwarding(void)
 {
@@ -853,7 +853,7 @@ static int networkStartNetworkDaemon(virConnectPtr conn,
         goto err_delbr1;
 
     if (network->def->forwardType != VIR_NETWORK_FORWARD_NONE &&
-        !networkEnableIpForwarding()) {
+        networkEnableIpForwarding() < 0) {
         virReportSystemError(conn, errno, "%s",
                              _("failed to enable IP forwarding"));
         goto err_delbr2;