]> git.ipfire.org Git - dbl.git/commitdiff
exporter: Create the RRset only once
authorMichael Tremer <michael.tremer@ipfire.org>
Wed, 10 Dec 2025 16:09:53 +0000 (16:09 +0000)
committerMichael Tremer <michael.tremer@ipfire.org>
Wed, 10 Dec 2025 16:09:53 +0000 (16:09 +0000)
Since all records have the same rrset, we simply create it only once
instead of doing this every time we iterate over our loop.

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>
src/dnsbl/exporters.py

index 60a4ece73990478b21681a75da1a980fd2f9925a..c2ffd331db30902969d2b8f5ecb2cb10f8cae33f 100644 (file)
@@ -186,13 +186,18 @@ class ZoneExporter(TextExporter):
 
                # XXX Add NS
 
+               # Compute the rrset
+               rrset = dns.rdataset.from_text(
+                       dns.rdataclass.IN, self.type, ttl, self.content,
+               )
+
                # Write all domains
                for domain in self.list.domains:
                        zone.replace_rdataset(
-                               dns.name.from_text("%s.%s" % (domain, self.list.zone), origin=origin),
-                               dns.rdataset.from_text(
-                                       dns.rdataclass.IN, self.type, ttl, self.content,
+                               dns.name.from_text(
+                                       "%s.%s" % (domain, self.list.zone), origin=origin,
                                ),
+                               rrset,
                        )
 
                # Add ZONEMD