]> git.ipfire.org Git - thirdparty/ipxe.git/commitdiff
[iscsi] Add missing "break" statements
authorMichael Brown <mcb30@ipxe.org>
Tue, 28 Jul 2015 13:11:35 +0000 (14:11 +0100)
committerMichael Brown <mcb30@ipxe.org>
Tue, 28 Jul 2015 13:15:14 +0000 (14:15 +0100)
iscsi_tx_done() is missing "break" statements at the end of each case.
(Fortunately, this happens not to cause a bug in practice, since
iscsi_login_request_done() is effectively a no-op when completing a
data-out PDU.)

Reported-by: Wissam Shoukair <wissams@mellanox.com>
Signed-off-by: Michael Brown <mcb30@ipxe.org>
src/net/tcp/iscsi.c

index 0099bf5bdb2cd7943f7a65db0c227cc0abf4a587..019a4c14e034abcd3a67376577bba6371c937a43 100644 (file)
@@ -1439,8 +1439,10 @@ static void iscsi_tx_done ( struct iscsi_session *iscsi ) {
        switch ( common->opcode & ISCSI_OPCODE_MASK ) {
        case ISCSI_OPCODE_DATA_OUT:
                iscsi_data_out_done ( iscsi );
+               break;
        case ISCSI_OPCODE_LOGIN_REQUEST:
                iscsi_login_request_done ( iscsi );
+               break;
        default:
                /* No action */
                break;