Bug 337747: config.cgi fails with an SQL error in Bugzilla::Keyword with no keywords...

Patch by Colin Ogilvie <colin.ogilvie@gmail.com>; r=mkanat; a=justdave

diff --git a/Bugzilla/Keyword.pm b/Bugzilla/Keyword.pm
index fb2e3ae66aa1988920342def401aa8f1306ae27b..946d43c141fb98f6a20fa4a6dbe180f4a3add881 100644 (file)
--- a/Bugzilla/Keyword.pm
+++ b/Bugzilla/Keyword.pm
@@ -82,7 +82,7 @@ sub new_from_list {
     my $dbh = Bugzilla->dbh;
 
     my $keywords;
-    if ($id_list) {
+    if (@$id_list) {
         my @detainted_ids;
         foreach my $id (@$id_list) {
             detaint_natural($id) ||
@@ -94,9 +94,7 @@ sub new_from_list {
             "SELECT $columns FROM keyworddefs WHERE id IN (" 
             . join(',', @detainted_ids) . ")", {Slice=>{}});
     } else {
-        ThrowCodeError('bad_arg',
-            {argument => 'id_list',
-             function => 'Bugzilla::Keyword::new_from_list'});
+        return [];
     }
 
     foreach my $keyword (@$keywords) {