]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
spi: rockchip: Drop unused and broken CR0 macros
authorJohn Madieu <john.madieu@gmail.com>
Sat, 25 Apr 2026 09:29:35 +0000 (09:29 +0000)
committerMark Brown <broonie@kernel.org>
Sun, 26 Apr 2026 21:57:20 +0000 (06:57 +0900)
Two CTRLR0 macros are defined but never referenced, and both are wrong:

 - CR0_XFM_MASK shifts by SPI_XFM_OFFSET, which does not exist anywhere
   in the tree. The intended symbol is CR0_XFM_OFFSET.

 - CR0_MTM_OFFSET is defined as 0x21, i.e. bit 33 of a 32-bit register.
   The value is meaningless and the macro is unused.

Drop both. They can be re-introduced correctly when an actual user
appears.

Signed-off-by: John Madieu <john.madieu@gmail.com>
Link: https://patch.msgid.link/20260425092936.2590132-3-john.madieu@gmail.com
Signed-off-by: Mark Brown <broonie@kernel.org>
drivers/spi/spi-rockchip.c

index de39f5da62cb58701ce1b0b1a82d8a90ca81f3a6..231fbcf0e7aafd312a36dc953ce977ed786069b6 100644 (file)
@@ -98,7 +98,6 @@
 #define CR0_FRF_MICROWIRE                      0x2
 
 #define CR0_XFM_OFFSET                         18
-#define CR0_XFM_MASK                           (0x03 << SPI_XFM_OFFSET)
 #define CR0_XFM_TR                                     0x0
 #define CR0_XFM_TO                                     0x1
 #define CR0_XFM_RO                                     0x2
 
 #define CR0_SOI_OFFSET                         23
 
-#define CR0_MTM_OFFSET                         0x21
-
 /* Bit fields in SER, 2bit */
 #define SER_MASK                                       0x3