http: fix condition check

Ticket: 7309

Do not use a constant expression in a condition

diff --git a/src/app-layer-htp.c b/src/app-layer-htp.c
index 3f3037ca30a1c47282bae63d4e259b2af3915ef9..f3101fde709a5f431af288a82dcc341f06da6052 100644 (file)
--- a/src/app-layer-htp.c
+++ b/src/app-layer-htp.c
@@ -1168,7 +1168,7 @@ static void FlagDetectStateNewFile(HtpTxUserData *tx, int dir)
         if (dir == STREAM_TOSERVER) {
             SCLogDebug("DETECT_ENGINE_STATE_FLAG_FILE_NEW set");
             tx->tx_data.de_state->dir_state[0].flags |= DETECT_ENGINE_STATE_FLAG_FILE_NEW;
-        } else if (STREAM_TOCLIENT) {
+        } else if (dir == STREAM_TOCLIENT) {
             SCLogDebug("DETECT_ENGINE_STATE_FLAG_FILE_NEW set");
             tx->tx_data.de_state->dir_state[1].flags |= DETECT_ENGINE_STATE_FLAG_FILE_NEW;
         }