]> git.ipfire.org Git - thirdparty/libvirt.git/commitdiff
xend_internal: don't let invalid input provoke NULL dereference
authorJim Meyering <meyering@redhat.com>
Wed, 6 Jan 2010 11:59:21 +0000 (12:59 +0100)
committerJim Meyering <meyering@redhat.com>
Wed, 6 Jan 2010 20:52:25 +0000 (21:52 +0100)
* src/xen/xend_internal.c (xenDaemonOpen_unix): Do not dereference
a NULL "conn".  Move first deref to follow the "conn == NULL" test.

src/xen/xend_internal.c

index 827aac4b769b7ab006cbacc7fc4798d2b34d48d0..be033f5c1126cf1b6edb7c9894d1392585755ad4 100644 (file)
@@ -748,11 +748,12 @@ int
 xenDaemonOpen_unix(virConnectPtr conn, const char *path)
 {
     struct sockaddr_un *addr;
-    xenUnifiedPrivatePtr priv = (xenUnifiedPrivatePtr) conn->privateData;
+    xenUnifiedPrivatePtr priv;
 
     if ((conn == NULL) || (path == NULL))
         return (-1);
 
+    priv = (xenUnifiedPrivatePtr) conn->privateData;
     memset(&priv->addr, 0, sizeof(priv->addr));
     priv->addrfamily = AF_UNIX;
     /*