]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
devres: fix devres_get()
authorMasahiro Yamada <yamada.masahiro@socionext.com>
Wed, 15 Jul 2015 01:29:00 +0000 (10:29 +0900)
committerZefan Li <lizefan@huawei.com>
Wed, 27 Apr 2016 10:55:15 +0000 (18:55 +0800)
commit 64526370d11ce8868ca495723d595b61e8697fbf upstream.

Currently, devres_get() passes devres_free() the pointer to devres,
but devres_free() should be given with the pointer to resource data.

Fixes: 9ac7849e35f7 ("devres: device resource management")
Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Acked-by: Tejun Heo <tj@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Zefan Li <lizefan@huawei.com>
drivers/base/devres.c

index 524bf96c289f0abe8d677712b79635b3456b1ddf..06c541dc4d504687f167e66eeafdabe7bde1de33 100644 (file)
@@ -254,10 +254,10 @@ void * devres_get(struct device *dev, void *new_res,
        if (!dr) {
                add_dr(dev, &new_dr->node);
                dr = new_dr;
-               new_dr = NULL;
+               new_res = NULL;
        }
        spin_unlock_irqrestore(&dev->devres_lock, flags);
-       devres_free(new_dr);
+       devres_free(new_res);
 
        return dr->data;
 }