note todo for overlapping networks

e.g.

192.168/16 is allowed, and so is 192.168.1/24.  They're overlapping
and the second is unnecessary.

diff --git a/src/modules/proto_radius/proto_radius_udp.c b/src/modules/proto_radius/proto_radius_udp.c
index baa77644e91e5d7f4de8dafe24120e32880c5b08..c557ee81e8e8bff4a2452cef6ad0deb513790f31 100644 (file)
--- a/src/modules/proto_radius/proto_radius_udp.c
+++ b/src/modules/proto_radius/proto_radius_udp.c
@@ -1406,6 +1406,15 @@ static int mod_bootstrap(void *instance, CONF_SECTION *cs)
                                return -1;
                        }
 
+                       /*
+                        *      @todo - look for 192.168/16 followed
+                        *      by 192.168.1/24, or vice-versa.
+                        *      i.e. the networks MUST be disjoint!
+                        *
+                        *      Or maybe that can be added as a flag
+                        *      to fr_trie_alloc() ?
+                        */
+
                        /*
                         *      Insert the network into the trie.
                         *      Lookups will return the fr_ipaddr_t of