Coverity 1507484: dereference before null check

Reviewed-by: Hugo Landau <hlandau@openssl.org>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/18907)

diff --git a/ssl/tls_srp.c b/ssl/tls_srp.c
index 2f1d2198fd1ec923d8e28fa7e5fc3ae81257de25..962e4d70740560fc08822c89cf41631f64094e33 100644 (file)
--- a/ssl/tls_srp.c
+++ b/ssl/tls_srp.c
@@ -90,9 +90,9 @@ int SSL_SRP_CTX_free(SSL *s)
  */
 int ssl_srp_ctx_init_intern(SSL_CONNECTION *s)
 {
-    SSL_CTX *ctx = SSL_CONNECTION_GET_CTX(s);
+    SSL_CTX *ctx;
 
-    if (s == NULL || ctx == NULL)
+    if (s == NULL || (ctx = SSL_CONNECTION_GET_CTX(s)) == NULL)
         return 0;
 
     memset(&s->srp_ctx, 0, sizeof(s->srp_ctx));