app_queue: Member stuck as pending after forwarding previous call from queue

Queue member will get stuck in pending_members if queue calls a device
that is different from the one observed for state changes.

This patch removes members from pending_members as a result of channel stasis
events such as blind or attended transfers and hangup.

ASTERISK-26862 #close

Change-Id: I8bf6df487b9bb35726c08049ff25cdad5e357727

diff --git a/apps/app_queue.c b/apps/app_queue.c
index f7cee6a76c09033a072fc3bcf108933fe2fc050d..4027527d4bc9813fb6d87bb8f4dc5fbb7c52fb03 100644 (file)
--- a/apps/app_queue.c
+++ b/apps/app_queue.c
@@ -5510,6 +5510,13 @@ static int update_queue(struct call_queue *q, struct member *member, int callcom
                        member->membername, (long)member->lastcall);
                ao2_unlock(q);
        }
+       /* Member might never experience any direct status change (local
+        * channel with forwarding in particular). If that's the case,
+        * this is the last chance to remove it from pending or subsequent
+        * calls will not occur.
+        */
+       pending_members_remove(member);
+
        ao2_lock(q);
        q->callscompleted++;
        if (callcompletedinsl) {