]> git.ipfire.org Git - thirdparty/bind9.git/commitdiff
Silence unchecked return of dns_db_find()
authorMark Andrews <marka@isc.org>
Thu, 6 Feb 2020 00:02:55 +0000 (11:02 +1100)
committerMark Andrews <marka@isc.org>
Fri, 7 Feb 2020 10:43:26 +0000 (21:43 +1100)
190        dns_rdataset_init(&rdataset);
    3. Condition r == 0, taking true branch.
    4. Condition result, taking false branch.

CID 1452691 (#1 of 1): Unchecked return value (CHECKED_RETURN)
5. check_return: Calling dns_db_find without checking return
value (as is done elsewhere 39 out of 45 times).

191        check_assertion(dns_db_find(db1, dns_rootname, v2,
192                                    dns_rdatatype_soa, 0, 0, NULL,
193                                    name, &rdataset, NULL));

(cherry picked from commit e8bf82efc6dfffa7f17117617c6dfe32ce7ac96d)

lib/dns/tests/dbversion_test.c

index ca10d09e636c29a7031eeec9fad8c688aae1514e..5a429bcd48d63a188b0bc583d690c184fbceb89c 100644 (file)
@@ -188,9 +188,9 @@ find(void **state) {
        }
 
        dns_rdataset_init(&rdataset);
-       check_assertion(dns_db_find(db1, dns_rootname, v2,
-                                   dns_rdatatype_soa, 0, 0, NULL,
-                                   name, &rdataset, NULL));
+       check_assertion((void)dns_db_find(db1, dns_rootname, v2,
+                                         dns_rdatatype_soa, 0, 0, NULL,
+                                         name, &rdataset, NULL));
 }
 
 /*