]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
drm/panthor: Correct the order of arguments passed to gem_sync
authorAkash Goel <akash.goel@arm.com>
Thu, 5 Mar 2026 11:07:23 +0000 (11:07 +0000)
committerLiviu Dudau <liviu.dudau@arm.com>
Thu, 5 Mar 2026 16:53:09 +0000 (16:53 +0000)
This commit corrects the order of arguments passed to panthor_gem_sync()
function, called when the SYNC_WAIT condition has to be evaluated for a
blocked GPU queue.

Fixes: cd2c9c3015e6 ("drm/panthor: Add flag to map GEM object Write-Back Cacheable")
Signed-off-by: Akash Goel <akash.goel@arm.com>
Reviewed-by: Steven Price <steven.price@arm.com>
Reviewed-by: Boris Brezillon <boris.brezillon@collabora.com>
Reviewed-by: Liviu Dudau <liviu.dudau@arm.com>
Link: https://patch.msgid.link/20260305110723.2871733-1-akash.goel@arm.com
Signed-off-by: Liviu Dudau <liviu.dudau@arm.com>
drivers/gpu/drm/panthor/panthor_sched.c

index bd703a2904a168ca46e20ec80fd08126d23e20c7..a70f1db0764e93ee743c32b15bdfb4c66f7a8d7e 100644 (file)
@@ -893,14 +893,15 @@ panthor_queue_get_syncwait_obj(struct panthor_group *group, struct panthor_queue
 
 out_sync:
        /* Make sure the CPU caches are invalidated before the seqno is read.
-        * drm_gem_shmem_sync() is a NOP if map_wc=true, so no need to check
+        * panthor_gem_sync() is a NOP if map_wc=true, so no need to check
         * it here.
         */
-       panthor_gem_sync(&bo->base.base, queue->syncwait.offset,
+       panthor_gem_sync(&bo->base.base,
+                        DRM_PANTHOR_BO_SYNC_CPU_CACHE_FLUSH_AND_INVALIDATE,
+                        queue->syncwait.offset,
                         queue->syncwait.sync64 ?
                         sizeof(struct panthor_syncobj_64b) :
-                        sizeof(struct panthor_syncobj_32b),
-                        DRM_PANTHOR_BO_SYNC_CPU_CACHE_FLUSH_AND_INVALIDATE);
+                        sizeof(struct panthor_syncobj_32b));
 
        return queue->syncwait.kmap + queue->syncwait.offset;