Use pull request #11622 from ben-z/fix-smooth-scroll-options for v6.5.0

ae8363a3f Fix smoothscroll not applying custom options
8dd706557 fix: correctly remove the event listener in _destroy
9767057c2 fix: fix spelling

Signed-off-by: Nicolas Coden <nicolas@ncoden.fr>

diff --git a/js/foundation.smoothScroll.js b/js/foundation.smoothScroll.js
index 4674061c1f9b667e0308a0ead41508f0eb0d948f..68e38a70dea6a65ba9f36345c00e17c2e3b54bc5 100644 (file)
--- a/js/foundation.smoothScroll.js
+++ b/js/foundation.smoothScroll.js
@@ -39,8 +39,9 @@ class SmoothScroll extends Plugin {
      * @private
      */
     _events() {
-        this.$element.on('click.zf.smoothScroll', this._handleLinkClick)
-        this.$element.on('click.zf.smoothScroll', 'a[href^="#"]', this._handleLinkClick);
+        this._linkClickListener = this._handleLinkClick.bind(this);
+        this.$element.on('click.zf.smoothScroll', this._linkClickListener);
+        this.$element.on('click.zf.smoothScroll', 'a[href^="#"]', this._linkClickListener);
     }
 
     /**
@@ -97,8 +98,8 @@ class SmoothScroll extends Plugin {
      * @function
      */
     _destroy() {
-        this.$element.off('click.zf.smoothScroll', this._handleLinkClick)
-        this.$element.off('click.zf.smoothScroll', 'a[href^="#"]', this._handleLinkClick);
+        this.$element.off('click.zf.smoothScroll', this._linkClickListener)
+        this.$element.off('click.zf.smoothScroll', 'a[href^="#"]', this._linkClickListener);
     }
 }