]> git.ipfire.org Git - thirdparty/libvirt.git/commitdiff
qemu: remove extraneous error log when qemuPasstStart() fails during hotplug
authorLaine Stump <laine@redhat.com>
Tue, 21 Feb 2023 06:09:04 +0000 (01:09 -0500)
committerLaine Stump <laine@redhat.com>
Wed, 22 Feb 2023 13:21:48 +0000 (08:21 -0500)
qemuPasstStart() already logs any error that occurs, so having the
caller log a generic error message only serves to obscure the actual
problem.

Fixes: a56f0168d576fa01cec204dc3c67d4d63ab8487f
Signed-off-by: Laine Stump <laine@redhat.com>
Reviewed-by: Michal Privoznik <mprivozn@redhat.com>
src/qemu/qemu_hotplug.c

index b4cddef9f5be78fd278218f279998965705e7483..da175258249bec2e50b079b8b430607397fa5041 100644 (file)
@@ -1205,11 +1205,8 @@ qemuDomainAttachNetDevice(virQEMUDriver *driver,
     case VIR_DOMAIN_NET_TYPE_USER:
         if (net->backend.type == VIR_DOMAIN_NET_BACKEND_PASST) {
 
-            if (qemuPasstStart(vm, net) < 0) {
-                virReportError(VIR_ERR_INTERNAL_ERROR,
-                               "%s", _("Failed to start passt"));
+            if (qemuPasstStart(vm, net) < 0)
                 goto cleanup;
-            }
 
         } else if (!priv->disableSlirp &&
                    virQEMUCapsGet(priv->qemuCaps, QEMU_CAPS_DBUS_VMSTATE)) {