]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
drm/xe/migrate: fix job lock assert
authorMatthew Auld <matthew.auld@intel.com>
Tue, 20 Jan 2026 11:06:11 +0000 (11:06 +0000)
committerThomas Hellström <thomas.hellstrom@linux.intel.com>
Wed, 21 Jan 2026 14:24:22 +0000 (15:24 +0100)
We are meant to be checking the user vm for the bind queue, but actually
we are checking the migrate vm. For various reasons this is not
currently firing but this will likely change in the future.

Now that we have the user_vm attached to the bind queue, we can fix this
by directly checking that here.

Fixes: dba89840a920 ("drm/xe: Add GT TLB invalidation jobs")
Signed-off-by: Matthew Auld <matthew.auld@intel.com>
Cc: Thomas Hellström <thomas.hellstrom@linux.intel.com>
Cc: Matthew Brost <matthew.brost@intel.com>
Reviewed-by: Matthew Brost <matthew.brost@intel.com>
Reviewed-by: Arvind Yadav <arvind.yadav@intel.com>
Link: https://patch.msgid.link/20260120110609.77958-4-matthew.auld@intel.com
(cherry picked from commit 9dd1048bca4fe2aa67c7a286bafb3947537adedb)
Signed-off-by: Thomas Hellström <thomas.hellstrom@linux.intel.com>
drivers/gpu/drm/xe/xe_migrate.c

index 5a95b08a4723a1ef05fd43e1b7d63ed4d741556d..d8ee76aab4e41f6bbf4500e793aaa120444776a7 100644 (file)
@@ -2445,7 +2445,7 @@ void xe_migrate_job_lock(struct xe_migrate *m, struct xe_exec_queue *q)
        if (is_migrate)
                mutex_lock(&m->job_mutex);
        else
-               xe_vm_assert_held(q->vm);       /* User queues VM's should be locked */
+               xe_vm_assert_held(q->user_vm);  /* User queues VM's should be locked */
 }
 
 /**
@@ -2463,7 +2463,7 @@ void xe_migrate_job_unlock(struct xe_migrate *m, struct xe_exec_queue *q)
        if (is_migrate)
                mutex_unlock(&m->job_mutex);
        else
-               xe_vm_assert_held(q->vm);       /* User queues VM's should be locked */
+               xe_vm_assert_held(q->user_vm);  /* User queues VM's should be locked */
 }
 
 #if IS_ENABLED(CONFIG_PROVE_LOCKING)