]> git.ipfire.org Git - thirdparty/libvirt.git/commitdiff
qemu: command: use VIR_AUTOFREE in qemuBuildFSDevCommandLine
authorJán Tomko <jtomko@redhat.com>
Tue, 16 Jul 2019 08:37:03 +0000 (10:37 +0200)
committerJán Tomko <jtomko@redhat.com>
Tue, 16 Jul 2019 15:00:37 +0000 (17:00 +0200)
Introduce two separate variables instead of reusing the same one
for clarity.

Signed-off-by: Ján Tomko <jtomko@redhat.com>
Acked-by: Peter Krempa <pkrempa@redhat.com>
src/qemu/qemu_command.c

index 02a6642207de9b989cbff2f111d8799926394573..ef90dc5044c39f087f4dea700c693b2672783540 100644 (file)
@@ -2807,22 +2807,21 @@ qemuBuildFSDevCommandLine(virCommandPtr cmd,
                           const virDomainDef *def,
                           virQEMUCapsPtr qemuCaps)
 {
-    char *optstr;
+    VIR_AUTOFREE(char *) fsdevstr = NULL;
+    VIR_AUTOFREE(char *) devicestr = NULL;
 
     virCommandAddArg(cmd, "-fsdev");
-    if (!(optstr = qemuBuildFSStr(fs)))
+    if (!(fsdevstr = qemuBuildFSStr(fs)))
         return -1;
-    virCommandAddArg(cmd, optstr);
-    VIR_FREE(optstr);
+    virCommandAddArg(cmd, fsdevstr);
 
     if (qemuCommandAddExtDevice(cmd, &fs->info) < 0)
         return -1;
 
     virCommandAddArg(cmd, "-device");
-    if (!(optstr = qemuBuildFSDevStr(def, fs, qemuCaps)))
+    if (!(devicestr = qemuBuildFSDevStr(def, fs, qemuCaps)))
         return -1;
-    virCommandAddArg(cmd, optstr);
-    VIR_FREE(optstr);
+    virCommandAddArg(cmd, devicestr);
 
     return 0;
 }