]> git.ipfire.org Git - thirdparty/u-boot.git/commitdiff
rockchip: rk3188: remove setup_led from xPL
authorQuentin Schulz <quentin.schulz@cherry.de>
Wed, 12 Nov 2025 17:48:11 +0000 (18:48 +0100)
committerTom Rini <trini@konsulko.com>
Wed, 3 Dec 2025 17:03:45 +0000 (11:03 -0600)
There's not a single device making use of that code and it anyway
shouldn't be using the old deprecated u-boot,boot-led /config property
anymore but rather boot-led from /options/u-boot[1] Device Tree node.

Because spl_board_init() is only present to call this now removed
function, we can remove it as well as SPL_BOARD_INIT which is the symbol
guarding calls to spl_board_init() (which is now also removed).

[1] https://github.com/devicetree-org/dt-schema/blob/v2025.08/dtschema/schemas/options/u-boot.yaml#L113-L116

Signed-off-by: Quentin Schulz <quentin.schulz@cherry.de>
arch/arm/mach-rockchip/Kconfig
arch/arm/mach-rockchip/rk3188/rk3188.c

index 342933ca5099dbd1344a3b8dfc37061cd2c16d58..f78eaf52c2ad91b11ae385e57ec47e794bbd33d7 100644 (file)
@@ -76,7 +76,6 @@ config ROCKCHIP_RK3128
 config ROCKCHIP_RK3188
        bool "Support Rockchip RK3188"
        select CPU_V7A
-       select SPL_BOARD_INIT if SPL
        select SUPPORT_SPL
        select SPL
        select SPL_CLK
index 7cce1112fbdbc7bbbe34fddaab6aeb2d1f28cb6f..8aed46f0b3be279fde122d679c998f3e67a2bf67 100644 (file)
@@ -105,39 +105,3 @@ int rk_board_late_init(void)
 
        return rk3188_board_late_init();
 }
-
-#ifdef CONFIG_XPL_BUILD
-static int setup_led(void)
-{
-#ifdef CONFIG_SPL_LED
-       struct udevice *dev;
-       char *led_name;
-       int ret;
-
-       led_name = ofnode_conf_read_str("u-boot,boot-led");
-       if (!led_name)
-               return 0;
-       ret = led_get_by_label(led_name, &dev);
-       if (ret) {
-               debug("%s: get=%d\n", __func__, ret);
-               return ret;
-       }
-       ret = led_set_state(dev, LEDST_ON);
-       if (ret)
-               return ret;
-#endif
-
-       return 0;
-}
-
-void spl_board_init(void)
-{
-       int ret;
-
-       ret = setup_led();
-       if (ret) {
-               debug("LED ret=%d\n", ret);
-               hang();
-       }
-}
-#endif