kernel-yocto.bbclass: Reset to exiting on non-zero return code at end of task

Several tasks deactivate exiting on non-zero return codes via set +e because
they run subcommands that have legitimate non-zero return codes. However when
appending to those tasks, this behavior is not expected and can lead to builds
silently proceeding in case of an error. Therefore reset the default behavior
at the end of the respective tasks via set -e.

Signed-off-by: Stefan Wiehler <stefan.wiehler@nokia.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
(cherry picked from commit 83a6f28d2e464f00202090e998a63045adba9e4e)
Signed-off-by: Steve Sakoman <steve@sakoman.com>

diff --git a/meta/classes/kernel-yocto.bbclass b/meta/classes/kernel-yocto.bbclass
index a1a073b73882d6b7088647b655aed03811aae048..2a6231803b403e93167a57c8465c0d9e240be63a 100644 (file)
--- a/meta/classes/kernel-yocto.bbclass
+++ b/meta/classes/kernel-yocto.bbclass
@@ -269,6 +269,8 @@ do_kernel_metadata() {
                bbnote "KERNEL_FEATURES: $KERNEL_FEATURES_FINAL"
                bbnote "Final scc/cfg list: $sccs_defconfig $bsp_definition $sccs $KERNEL_FEATURES_FINAL"
        fi
+
+       set -e
 }
 
 do_patch() {
@@ -298,6 +300,8 @@ do_patch() {
                        fi
                done
        fi
+
+       set -e
 }
 
 do_kernel_checkout() {
@@ -356,6 +360,8 @@ do_kernel_checkout() {
                git commit -q -m "baseline commit: creating repo for ${PN}-${PV}"
                git clean -d -f
        fi
+
+       set -e
 }
 do_kernel_checkout[dirs] = "${S}"
 
@@ -523,6 +529,8 @@ do_validate_branches() {
                        kgit-s2q --clean
                fi
        fi
+
+       set -e
 }
 
 OE_TERMINAL_EXPORTS += "KBUILD_OUTPUT"