conf: log failure to create tty mountpoint

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

diff --git a/src/lxc/conf.c b/src/lxc/conf.c
index 8dcfc60f3f84ff0af71509b73f0c7cbaec95f718..37104761e452fab40b7851568ac7a4a42e48a044 100644 (file)
--- a/src/lxc/conf.c
+++ b/src/lxc/conf.c
@@ -946,11 +946,20 @@ static int open_ttymnt_at(int dfd, const char *path)
 {
        int fd;
 
-       fd = open_at(dfd, path, PROTECT_OPEN | O_CREAT | O_EXCL,
-                    PROTECT_LOOKUP_BENEATH, 0);
-       if (fd < 0 && (errno == ENXIO || errno == EEXIST))
-               fd = open_at(dfd, path, PROTECT_OPATH_FILE,
-                            PROTECT_LOOKUP_BENEATH, 0);
+       fd = open_at(dfd, path,
+                    PROTECT_OPEN | O_CREAT | O_EXCL,
+                    PROTECT_LOOKUP_BENEATH,
+                    0);
+       if (fd < 0) {
+               if (!IN_SET(errno, ENXIO, EEXIST))
+                       return syserror("Failed to create \"%d/\%s\"", dfd, path);
+
+               SYSINFO("Failed to create \"%d/\%s\"", dfd, path);
+               fd = open_at(dfd, path,
+                            PROTECT_OPATH_FILE,
+                            PROTECT_LOOKUP_BENEATH,
+                            0);
+       }
 
        return fd;
 }