Remove illogical condition from isc_buffer_reallocate that would return ISC_R_NOSPACE...

diff --git a/lib/isc/buffer.c b/lib/isc/buffer.c
index cecfecddd9348e16a0003316c30bdf34f692149d..166d1ded4d22446ae95222a72cb367d8e9a92f84 100644 (file)
--- a/lib/isc/buffer.c
+++ b/lib/isc/buffer.c
@@ -576,9 +576,6 @@ isc_buffer_reallocate(isc_buffer_t **dynbuffer, unsigned int length) {
        REQUIRE(ISC_BUFFER_VALID(*dynbuffer));
        REQUIRE((*dynbuffer)->mctx != NULL);
 
-       if ((*dynbuffer)->length > length)
-               return (ISC_R_NOSPACE);
-
        /*
         * XXXMUKS: This is far more expensive than plain realloc() as
         * it doesn't remap pages, but does ordinary copy. So is

diff --git a/lib/isc/tests/buffer_test.c b/lib/isc/tests/buffer_test.c
index 70f49161c593a9cbf57686be5f135b74b5ccb862..d584c51c23c3a675740ba095d78185fc4c7eb3f5 100644 (file)
--- a/lib/isc/tests/buffer_test.c
+++ b/lib/isc/tests/buffer_test.c
@@ -114,12 +114,6 @@ ATF_TC_BODY(isc_buffer_reallocate, tc) {
        ATF_REQUIRE(b != NULL);
        ATF_CHECK_EQ(b->length, 1024);
 
-       result = isc_buffer_reallocate(&b, 512);
-       ATF_CHECK_EQ(result, ISC_R_NOSPACE);
-       ATF_CHECK(ISC_BUFFER_VALID(b));
-       ATF_REQUIRE(b != NULL);
-       ATF_CHECK_EQ(b->length, 1024);
-
        result = isc_buffer_reallocate(&b, 1536);
        ATF_CHECK_EQ(result, ISC_R_SUCCESS);
        ATF_CHECK(ISC_BUFFER_VALID(b));