]> git.ipfire.org Git - thirdparty/hostap.git/commitdiff
FILS: Remove unused arguments from writing Association Response elements
authorAdil Saeed Musthafa <adilm@qti.qualcomm.com>
Mon, 24 Nov 2025 21:13:15 +0000 (13:13 -0800)
committerJouni Malinen <j@w1.fi>
Tue, 25 Nov 2025 12:21:27 +0000 (14:21 +0200)
The elements from the (Re)Association Request frame were never needed
for the FILS case and were likely originally included just because a
similar function for FT included them.

Signed-off-by: Adil Saeed Musthafa <adilm@qti.qualcomm.com>
src/ap/ieee802_11.c
src/ap/wpa_auth.h
src/ap/wpa_auth_ie.c

index 34987b5682fe15a5a10cf51f9756ff592b8e7bd1..3b21459ada9dbf72596e03ba75774ae6f9475ee7 100644 (file)
@@ -5477,8 +5477,7 @@ static u16 send_assoc_resp(struct hostapd_data *hapd, struct sta_info *sta,
             sta->auth_alg == WLAN_AUTH_FILS_SK_PFS ||
             sta->auth_alg == WLAN_AUTH_FILS_PK))
                p = wpa_auth_write_assoc_resp_fils(sta->wpa_sm, p,
-                                                  buf + buflen - p,
-                                                  ies, ies_len);
+                                                  buf + buflen - p);
 #endif /* CONFIG_FILS */
 
 #ifdef CONFIG_OWE
index fc95019e7703f776a9c6fa4c95b0b19a64053627..12a8b6b1a7f9002fcbaf72c657293cbb277419b5 100644 (file)
@@ -639,8 +639,7 @@ void wpa_auth_add_fils_pmk_pmkid(struct wpa_state_machine *sm, const u8 *pmk,
 u8 * wpa_auth_write_assoc_resp_owe(struct wpa_state_machine *sm,
                                   u8 *pos, size_t max_len);
 u8 * wpa_auth_write_assoc_resp_fils(struct wpa_state_machine *sm,
-                                   u8 *pos, size_t max_len,
-                                   const u8 *req_ies, size_t req_ies_len);
+                                   u8 *pos, size_t max_len);
 bool wpa_auth_write_fd_rsn_info(struct wpa_authenticator *wpa_auth,
                                u8 *fd_rsn_info);
 void wpa_auth_set_auth_alg(struct wpa_state_machine *sm, u16 auth_alg);
index 21ed31a4198a0d9aa1d077774f0b182c947477ab..220ac809f338ae016dfa1e76ac1220f198460cf7 100644 (file)
@@ -1442,8 +1442,7 @@ u8 * wpa_auth_write_assoc_resp_owe(struct wpa_state_machine *sm,
 #ifdef CONFIG_FILS
 
 u8 * wpa_auth_write_assoc_resp_fils(struct wpa_state_machine *sm,
-                                   u8 *pos, size_t max_len,
-                                   const u8 *req_ies, size_t req_ies_len)
+                                   u8 *pos, size_t max_len)
 {
        int res;