coverity: #1425748

Time of check time of use

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

diff --git a/src/lxc/conf.c b/src/lxc/conf.c
index 93876255136b9bf2cf0e013068bbf988fea8ac3e..f3feae7dff855a6db4154ef75a288d1c316a14b2 100644 (file)
--- a/src/lxc/conf.c
+++ b/src/lxc/conf.c
@@ -1541,16 +1541,11 @@ static int lxc_setup_devpts(struct lxc_conf *conf)
        if (ret < 0 || (size_t)ret >= sizeof(devpts_mntopts))
                return -1;
 
-       /* Unmount old devpts instance. */
-       ret = access("/dev/pts/ptmx", F_OK);
-       if (!ret) {
-               ret = umount("/dev/pts");
-               if (ret < 0) {
-                       SYSERROR("Failed to unmount old devpts instance");
-                       return -1;
-               }
+       ret = umount2("/dev/pts", MNT_DETACH);
+       if (ret < 0)
+               WARN("%s - Failed to unmount old devpts instance", strerror(errno));
+       else
                DEBUG("Unmounted old devpts instance");
-       }
 
        /* Create mountpoint for devpts instance. */
        ret = mkdir("/dev/pts", 0755);