ext4: Sync and invalidate metadata buffers from ext4_evict_inode()

There are only very few filesystems using generic metadata buffer head
tracking and everybody is paying the overhead. When we remove this
tracking for inode reclaim code .evict will start to see inodes with
metadata buffers attached so write them out and prune them.

Acked-by: Theodore Ts'o <tytso@mit.edu>
Signed-off-by: Jan Kara <jack@suse.cz>
Link: https://patch.msgid.link/20260326095354.16340-61-jack@suse.cz
Tested-by: syzbot@syzkaller.appspotmail.com
Signed-off-by: Christian Brauner <brauner@kernel.org>

diff --git a/fs/ext4/inode.c b/fs/ext4/inode.c
index d18d94acddcc16971946a9cfecc69cc83f1dbdf2..6f892abef003c1d22ba539682a4bfd964e6b0196 100644 (file)
--- a/fs/ext4/inode.c
+++ b/fs/ext4/inode.c
@@ -185,7 +185,9 @@ void ext4_evict_inode(struct inode *inode)
                ext4_evict_ea_inode(inode);
        if (inode->i_nlink) {
                truncate_inode_pages_final(&inode->i_data);
-
+               /* Avoid mballoc special inode which has no proper iops */
+               if (!EXT4_SB(inode->i_sb)->s_journal)
+                       sync_mapping_buffers(&inode->i_data);
                goto no_delete;
        }
 

diff --git a/fs/ext4/super.c b/fs/ext4/super.c
index 43f680c750ae6b2cacb35bcaad262ba234676ef4..ea827b0ecc8dc5403d9f27ce6e279eef5e16aac4 100644 (file)
--- a/fs/ext4/super.c
+++ b/fs/ext4/super.c
@@ -1524,7 +1524,8 @@ static void destroy_inodecache(void)
 void ext4_clear_inode(struct inode *inode)
 {
        ext4_fc_del(inode);
-       invalidate_inode_buffers(inode);
+       if (!EXT4_SB(inode->i_sb)->s_journal)
+               invalidate_inode_buffers(inode);
        clear_inode(inode);
        ext4_discard_preallocations(inode);
        ext4_es_remove_extent(inode, 0, EXT_MAX_BLOCKS);