Fix a file descriptor leak in the monitord spawn

Signed-off-by: Vincent Giersch <vincent.giersch@ovh.net>
Acked-by: Stéphane Graber <stgraber@ubuntu.com>

diff --git a/src/lxc/monitor.c b/src/lxc/monitor.c
index f356adf2178ab770205375daa2cdcd26a00ab555..7c6dbb4a565cefaa658fe7fef23953f8f69d984c 100644 (file)
--- a/src/lxc/monitor.c
+++ b/src/lxc/monitor.c
@@ -319,6 +319,7 @@ int lxc_monitord_spawn(const char *lxcpath)
                SYSERROR("failed to setsid");
                exit(EXIT_FAILURE);
        }
+       lxc_check_inherited(NULL, pipefd[1]);
        close(0);
        close(1);
        close(2);

diff --git a/src/lxc/start.c b/src/lxc/start.c
index e6b4895cd90c2cdfa8b38ea6cb1ead08a030b834..26763346c97babedd6f34946a23ee386cae84778 100644 (file)
--- a/src/lxc/start.c
+++ b/src/lxc/start.c
@@ -203,7 +203,7 @@ restart:
                if (match_fd(fd))
                        continue;
 
-               if (conf->close_all_fds) {
+               if (conf == NULL || conf->close_all_fds) {
                        close(fd);
                        closedir(dir);
                        INFO("closed inherited fd %d", fd);