]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
gpib: ni_usb: Fix the *allocate_private retval check
authorDominik Karol Piątkowski <dominik.karol.piatkowski@protonmail.com>
Fri, 16 Jan 2026 17:48:59 +0000 (17:48 +0000)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 27 Jan 2026 15:04:08 +0000 (16:04 +0100)
Change

if (retval < 0)
        return retval;

into

if (retval)
        return retval;

as it is more fitting in this case.

Signed-off-by: Dominik Karol Piątkowski <dominik.karol.piatkowski@protonmail.com>
Link: https://patch.msgid.link/20260116174647.317256-22-dominik.karol.piatkowski@protonmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/gpib/ni_usb/ni_usb_gpib.c

index b062360fff000b16a1d21d3a1d4e415baf82c716..c6f1a70d44f5d895efb0446d57178045c7f62608 100644 (file)
@@ -2234,7 +2234,7 @@ static int ni_usb_attach(struct gpib_board *board, const struct gpib_board_confi
 
        mutex_lock(&ni_usb_hotplug_lock);
        retval = ni_usb_allocate_private(board);
-       if (retval < 0)         {
+       if (retval) {
                mutex_unlock(&ni_usb_hotplug_lock);
                return retval;
        }