]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
media: atomisp: gc0310: Use V4L2_CID_ANALOGUE_GAIN for gain control
authorHans de Goede <hansg@kernel.org>
Fri, 4 Jul 2025 20:54:19 +0000 (22:54 +0200)
committerMauro Carvalho Chehab <mchehab+huawei@kernel.org>
Tue, 8 Jul 2025 06:43:29 +0000 (08:43 +0200)
Use V4L2_CID_ANALOGUE_GAIN for gain control, as expected by userspace.

Signed-off-by: Hans de Goede <hansg@kernel.org>
Link: https://lore.kernel.org/r/20250517114106.43494-6-hdegoede@redhat.com
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
drivers/staging/media/atomisp/i2c/atomisp-gc0310.c

index 91f95db9428360efb2db5c153dcb629946b99dba..1f1795fc625ffe1e6d2ac14512835f608347e816 100644 (file)
@@ -289,7 +289,7 @@ static int gc0310_s_ctrl(struct v4l2_ctrl *ctrl)
                ret = cci_write(sensor->regmap, GC0310_AEC_PK_EXPO_REG,
                                ctrl->val, NULL);
                break;
-       case V4L2_CID_GAIN:
+       case V4L2_CID_ANALOGUE_GAIN:
                ret = gc0310_gain_set(sensor, ctrl->val);
                break;
        default:
@@ -533,7 +533,7 @@ static int gc0310_init_controls(struct gc0310_device *sensor)
 
        /* 32 steps at base gain 1 + 64 half steps at base gain 2 */
        sensor->ctrls.gain =
-               v4l2_ctrl_new_std(hdl, &ctrl_ops, V4L2_CID_GAIN, 0, 95, 1, 31);
+               v4l2_ctrl_new_std(hdl, &ctrl_ops, V4L2_CID_ANALOGUE_GAIN, 0, 95, 1, 31);
 
        return hdl->error;
 }