lambda refactor post-production fixes

comments from 77c9534dcaf3723f7b2baf42442eda3e1d8c3332
addressed

Change-Id: I09ae6429ecc89f6fd0949d7d5f1fb4d977e91ad4

diff --git a/doc/build/core/connections.rst b/doc/build/core/connections.rst
index 629bec333abafdc70b6c89648c7474475615132d..1bb784068de67d42bee0959d43c3149fd5a32491 100644 (file)
--- a/doc/build/core/connections.rst
+++ b/doc/build/core/connections.rst
@@ -1316,7 +1316,7 @@ Basic guidelines include:
   creates a cache key from other closure variables within the statement.  In order
   to provide the best guarantee of an accurate cache key, all objects located
   in the closure of the lambda are considered to be significant, and none
-  will none will be assumed to be appropriate for a cache key by default.
+  will be assumed to be appropriate for a cache key by default.
   So the following example will also raise a rather detailed error message::
 
     >>> class Foo:

diff --git a/lib/sqlalchemy/orm/util.py b/lib/sqlalchemy/orm/util.py
index 88f9a34d056e4a723537b82d1f6c09dc37de12d9..bbb428683e490bb3aa94b3093f9c9c3a1ce2d30b 100644 (file)
--- a/lib/sqlalchemy/orm/util.py
+++ b/lib/sqlalchemy/orm/util.py
@@ -995,7 +995,7 @@ class LoaderCriteriaOption(CriteriaOption):
             :meth:`_orm.SessionEvents.do_orm_execute` event.
 
         :param track_closure_variables: when False, closure variables inside
-         of a lambda expression will not be validated used as part of
+         of a lambda expression will not be used as part of
          any cache key.    This allows more complex expressions to be used
          inside of a lambda expression but requires that the lambda ensures
          it returns the identical SQL every time given a particular class.

diff --git a/test/orm/test_selectin_relations.py b/test/orm/test_selectin_relations.py
index 4b486f87174a4b6f423056d4d8798c2afe4a189b..de6282da57ea16bc9738aebf975b54cc1cd89ee3 100644 (file)
--- a/test/orm/test_selectin_relations.py
+++ b/test/orm/test_selectin_relations.py
@@ -722,7 +722,6 @@ class EagerTest(_fixtures.FixtureTest, testing.AssertsCompiledSQL):
             )
 
         self.assert_sql_count(testing.db, go, count)
-        return
 
         eq_(
             sess.query(User)