HID: amd_sfh: Add NULL check for hid device

[ Upstream commit 06aa2a43c307cf4096f422dcb575e5d2913e528f ]

On removal of hid device during SFH set report may cause NULL pointer
exception. Hence add NULL check for hid device before accessing.

Fixes: 4b2c53d93a4b ("SFH:Transport Driver to add support of AMD Sensor Fusion Hub (SFH)")
Signed-off-by: Basavaraj Natikar <Basavaraj.Natikar@amd.com>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
Signed-off-by: Sasha Levin <sashal@kernel.org>

diff --git a/drivers/hid/amd-sfh-hid/amd_sfh_hid.c b/drivers/hid/amd-sfh-hid/amd_sfh_hid.c
index e2a9679e32be8255adff6db70aab68e4e895ee61..54fe224050f95afc8444ab5141108bf58af1583e 100644 (file)
--- a/drivers/hid/amd-sfh-hid/amd_sfh_hid.c
+++ b/drivers/hid/amd-sfh-hid/amd_sfh_hid.c
@@ -100,11 +100,15 @@ static int amdtp_wait_for_response(struct hid_device *hid)
 
 void amdtp_hid_wakeup(struct hid_device *hid)
 {
-       struct amdtp_hid_data *hid_data = hid->driver_data;
-       struct amdtp_cl_data *cli_data = hid_data->cli_data;
+       struct amdtp_hid_data *hid_data;
+       struct amdtp_cl_data *cli_data;
 
-       cli_data->request_done[cli_data->cur_hid_dev] = true;
-       wake_up_interruptible(&hid_data->hid_wait);
+       if (hid) {
+               hid_data = hid->driver_data;
+               cli_data = hid_data->cli_data;
+               cli_data->request_done[cli_data->cur_hid_dev] = true;
+               wake_up_interruptible(&hid_data->hid_wait);
+       }
 }
 
 static struct hid_ll_driver amdtp_hid_ll_driver = {