]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
octeontx2-pf: handle otx2_mbox_get_rsp errors in otx2_common.c
authorDipendra Khadka <kdipendra88@gmail.com>
Thu, 17 Oct 2024 18:56:33 +0000 (18:56 +0000)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 14 Dec 2024 18:50:55 +0000 (19:50 +0100)
[ Upstream commit 0fbc7a5027c6f7f2c785adae3dcec22b2f2b69b3 ]

Add error pointer check after calling otx2_mbox_get_rsp().

Fixes: ab58a416c93f ("octeontx2-pf: cn10k: Get max mtu supported from admin function")
Signed-off-by: Dipendra Khadka <kdipendra88@gmail.com>
Reviewed-by: Simon Horman <horms@kernel.org>
Signed-off-by: Andrew Lunn <andrew@lunn.ch>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.c

index 6b024d29eaf32b093e911c2486fd56a0b7646996..8333340b1ea9f8d2bab604d49bdc98c8d8df0fac 100644 (file)
@@ -1696,6 +1696,10 @@ u16 otx2_get_max_mtu(struct otx2_nic *pfvf)
        if (!rc) {
                rsp = (struct nix_hw_info *)
                       otx2_mbox_get_rsp(&pfvf->mbox.mbox, 0, &req->hdr);
+               if (IS_ERR(rsp)) {
+                       rc = PTR_ERR(rsp);
+                       goto out;
+               }
 
                /* HW counts VLAN insertion bytes (8 for double tag)
                 * irrespective of whether SQE is requesting to insert VLAN