]> git.ipfire.org Git - thirdparty/gcc.git/commitdiff
gccrs: backend: Use new name resolver where necessary
authorArthur Cohen <arthur.cohen@embecosm.com>
Fri, 25 Aug 2023 12:33:36 +0000 (14:33 +0200)
committerArthur Cohen <arthur.cohen@embecosm.com>
Thu, 1 Aug 2024 14:52:24 +0000 (16:52 +0200)
gcc/rust/ChangeLog:

* backend/rust-compile-base.cc: Use new ImmutableNrCtx.
* backend/rust-compile-context.h: Likewise.
* backend/rust-compile-expr.cc: Likewise.
* backend/rust-compile-item.cc: Likewise.

gcc/rust/backend/rust-compile-base.cc
gcc/rust/backend/rust-compile-context.h
gcc/rust/backend/rust-compile-expr.cc
gcc/rust/backend/rust-compile-item.cc

index 4d6f0275b004b378a9e80c6e903c1f5d732e34d6..584d6a03ea954496da9c39a5a64d32f3249bc09d 100644 (file)
@@ -31,6 +31,7 @@
 #include "rust-type-util.h"
 #include "rust-compile-implitem.h"
 #include "rust-attribute-values.h"
+#include "rust-immutable-name-resolution-context.h"
 
 #include "fold-const.h"
 #include "stringpool.h"
index 36a36e79f6805f3cd9d3375072b61690ada6e919..671aee196c2aace5796870ce4e9faf3f5db714ed 100644 (file)
@@ -27,6 +27,7 @@
 #include "rust-hir-full.h"
 #include "rust-mangle.h"
 #include "rust-tree.h"
+#include "rust-immutable-name-resolution-context.h"
 
 namespace Rust {
 namespace Compile {
index 65de24bf9d8c5d50e53a9ccd19cbb9045bceb9a7..6a9bb73ffe0f30651188423f407a1017353cf6b7 100644 (file)
@@ -2311,11 +2311,23 @@ CompileExpr::generate_closure_function (HIR::ClosureExpr &expr,
   if (is_block_expr)
     {
       auto body_mappings = function_body->get_mappings ();
-      Resolver::Rib *rib = nullptr;
-      bool ok
-       = ctx->get_resolver ()->find_name_rib (body_mappings.get_nodeid (),
-                                              &rib);
-      rust_assert (ok);
+      if (flag_name_resolution_2_0)
+       {
+         auto nr_ctx
+           = Resolver2_0::ImmutableNameResolutionContext::get ().resolver ();
+
+         auto candidate = nr_ctx.values.to_rib (body_mappings.get_nodeid ());
+
+         rust_assert (candidate.has_value ());
+       }
+      else
+       {
+         Resolver::Rib *rib = nullptr;
+         bool ok
+           = ctx->get_resolver ()->find_name_rib (body_mappings.get_nodeid (),
+                                                  &rib);
+         rust_assert (ok);
+       }
     }
 
   tree enclosing_scope = NULL_TREE;
index 234ad2aa59c1529e96a9f47ba7ba5356207770f0..8feed51efa4fe23d883140c91b5b57eea2c5122c 100644 (file)
@@ -19,6 +19,7 @@
 #include "rust-compile-item.h"
 #include "rust-compile-implitem.h"
 #include "rust-compile-extern.h"
+#include "rust-immutable-name-resolution-context.h"
 
 namespace Rust {
 namespace Compile {
@@ -149,12 +150,30 @@ CompileItem::visit (HIR::Function &function)
        }
     }
 
-  const Resolver::CanonicalPath *canonical_path = nullptr;
-  bool ok = ctx->get_mappings ()->lookup_canonical_path (
-    function.get_mappings ().get_nodeid (), &canonical_path);
-  rust_assert (ok);
+  Resolver::CanonicalPath canonical_path
+    = Resolver::CanonicalPath::create_empty ();
+
+  if (flag_name_resolution_2_0)
+    {
+      auto nr_ctx
+       = Resolver2_0::ImmutableNameResolutionContext::get ().resolver ();
+
+      auto path = nr_ctx.values.to_canonical_path (
+       function.get_mappings ().get_nodeid ());
+
+      canonical_path = path.value ();
+    }
+  else
+    {
+      const Resolver::CanonicalPath *path = nullptr;
+      bool ok = ctx->get_mappings ()->lookup_canonical_path (
+       function.get_mappings ().get_nodeid (), &path);
+      rust_assert (ok);
+
+      canonical_path = *path;
+    }
 
-  const std::string asm_name = ctx->mangle_item (fntype, *canonical_path);
+  const std::string asm_name = ctx->mangle_item (fntype, canonical_path);
 
   // items can be forward compiled which means we may not need to invoke this
   // code. We might also have already compiled this generic function as well.
@@ -181,7 +200,7 @@ CompileItem::visit (HIR::Function &function)
                        function.get_function_params (),
                        function.get_qualifiers (), function.get_visibility (),
                        function.get_outer_attrs (), function.get_locus (),
-                       function.get_definition ().get (), canonical_path,
+                       function.get_definition ().get (), &canonical_path,
                        fntype);
   reference = address_expression (fndecl, ref_locus);