]> git.ipfire.org Git - thirdparty/dovecot/core.git/commitdiff
fts-lucene: Do not clobber return value
authorAki Tuomi <aki.tuomi@dovecot.fi>
Wed, 1 Nov 2017 16:04:57 +0000 (18:04 +0200)
committerAki Tuomi <aki.tuomi@dovecot.fi>
Wed, 1 Nov 2017 16:04:57 +0000 (18:04 +0200)
Found by scanbuild

src/plugins/fts-lucene/fts-backend-lucene.c

index e839838b100d1c8c63396489944a949db2556bb0..9b8e6e5bfe6f9ab15fca1fd5d80e11798d88a5c1 100644 (file)
@@ -263,6 +263,7 @@ fts_backend_lucene_update_deinit(struct fts_backend_update_context *_ctx)
        if (ctx->expunge_ctx != NULL) {
                if (fts_expunge_log_append_commit(&ctx->expunge_ctx) < 0) {
                        struct stat st;
+                       ret = -1;
 
                        if (stat(backend->dir_path, &st) < 0 && errno == ENOENT) {
                                /* lucene-indexes directory doesn't even exist,
@@ -271,7 +272,6 @@ fts_backend_lucene_update_deinit(struct fts_backend_update_context *_ctx)
                                (void)lucene_index_rescan(backend->index);
                                ret = 0;
                        }
-                       ret = -1;
                }
        }